Skip to content

Enable breakingProto#55

Merged
masihyeganeh merged 4 commits into
masterfrom
enable-breaking-proto
Dec 22, 2025
Merged

Enable breakingProto#55
masihyeganeh merged 4 commits into
masterfrom
enable-breaking-proto

Conversation

@masihyeganeh

@masihyeganeh masihyeganeh commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@masihyeganeh masihyeganeh requested a review from a team as a code owner December 18, 2025 10:13
@masihyeganeh masihyeganeh requested review from TxCorpi0x, miladz68 and ysv and removed request for a team December 18, 2025 10:13
ysv
ysv previously approved these changes Dec 18, 2025

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @TxCorpi0x)

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @miladz68 and @TxCorpi0x).

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miladz68 reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x).

@masihyeganeh masihyeganeh merged commit f466abe into master Dec 22, 2025
9 checks passed
@masihyeganeh masihyeganeh deleted the enable-breaking-proto branch December 22, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants