fix audit report issues from Certik#50
Conversation
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @TxCorpi0x)
x/pse/keeper/hooks.go line 72 at r1 (raw file):
delegationTimeEntry, err := h.k.GetDelegationTimeEntry(ctx, valAddr, delAddr) if err != nil { if errors.Is(err, collections.ErrNotFound) {
shall we add test for this case ?
or it is not reproducible ?
miladz68
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @TxCorpi0x, and @ysv)
x/pse/keeper/hooks.go line 72 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
shall we add test for this case ?
or it is not reproducible ?
it is not reproducible, we are only adding it to satisfy Certik's comment.
ysv
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @TxCorpi0x)
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
Description
Reviewers checklist:
Authors checklist
This change is