Skip to content

fix audit report issues from Certik#50

Merged
miladz68 merged 2 commits into
masterfrom
milad/pse-fix-audit-reports
Dec 12, 2025
Merged

fix audit report issues from Certik#50
miladz68 merged 2 commits into
masterfrom
milad/pse-fix-audit-reports

Conversation

@miladz68

@miladz68 miladz68 commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner December 11, 2025 10:04
@miladz68 miladz68 requested review from TxCorpi0x, masihyeganeh and ysv and removed request for a team December 11, 2025 10:04

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @miladz68, and @TxCorpi0x)


x/pse/keeper/hooks.go line 72 at r1 (raw file):

	delegationTimeEntry, err := h.k.GetDelegationTimeEntry(ctx, valAddr, delAddr)
	if err != nil {
		if errors.Is(err, collections.ErrNotFound) {

shall we add test for this case ?
or it is not reproducible ?

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @TxCorpi0x, and @ysv)


x/pse/keeper/hooks.go line 72 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

shall we add test for this case ?
or it is not reproducible ?

it is not reproducible, we are only adding it to satisfy Certik's comment.

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @TxCorpi0x)

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@miladz68 miladz68 merged commit b6e14ec into master Dec 12, 2025
9 checks passed
@miladz68 miladz68 deleted the milad/pse-fix-audit-reports branch December 12, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants