Skip to content

implemented disable distribution gov proposal in pse module#41

Merged
miladz68 merged 7 commits into
masterfrom
milad/pse-disable-distribution
Dec 9, 2025
Merged

implemented disable distribution gov proposal in pse module#41
miladz68 merged 7 commits into
masterfrom
milad/pse-disable-distribution

Conversation

@miladz68

@miladz68 miladz68 commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner December 3, 2025 09:06
@miladz68 miladz68 requested review from TxCorpi0x, masihyeganeh and ysv and removed request for a team December 3, 2025 09:06

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @miladz68, and @TxCorpi0x)


a discussion (no related file):
verifying if gov integration is correct


x/pse/keeper/keeper.go line 38 at r1 (raw file):

	AccountScoreSnapshot     collections.Map[sdk.AccAddress, sdkmath.Int]
	AllocationSchedule       collections.Map[uint64, types.ScheduledDistribution] // Map: timestamp -> ScheduledDistribution
	DisableDistributionsColl collections.Item[bool]

by Coll do you mean collections ?

Maybe you want to name

  • store: DistributionsDisabled / DistributionsDisabled{Some_Suffix}
  • func/actions: DisableDistributions

or these are too similar and might be confusing ?

I'm also ok to keep current version

Code quote:

DisableDistributionsColl

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 8 of 20 files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @TxCorpi0x, and @ysv)


a discussion (no related file):

Previously, ysv (Yaroslav Savchuk) wrote…

verifying if gov integration is correct

what do we need to do here ?


x/pse/keeper/keeper.go line 38 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

by Coll do you mean collections ?

Maybe you want to name

  • store: DistributionsDisabled / DistributionsDisabled{Some_Suffix}
  • func/actions: DisableDistributions

or these are too similar and might be confusing ?

I'm also ok to keep current version

Done.

ysv
ysv previously approved these changes Dec 4, 2025

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 12 of 12 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @TxCorpi0x)

TxCorpi0x
TxCorpi0x previously approved these changes Dec 5, 2025

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 8 of 19 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@miladz68 miladz68 dismissed stale reviews from TxCorpi0x and ysv via 11a269c December 5, 2025 11:23

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 6 of 6 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@miladz68 miladz68 merged commit c4d0641 into master Dec 9, 2025
15 of 16 checks passed
@miladz68 miladz68 deleted the milad/pse-disable-distribution branch December 9, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants