Skip to content

fix tests which are broken from previous PRs#26

Merged
miladz68 merged 3 commits into
masterfrom
milad/fix-pse-tests
Nov 18, 2025
Merged

fix tests which are broken from previous PRs#26
miladz68 merged 3 commits into
masterfrom
milad/fix-pse-tests

Conversation

@miladz68

@miladz68 miladz68 commented Nov 17, 2025 •
edited by ysv
Loading

Copy link
Copy Markdown
Contributor

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner November 17, 2025 10:31
@miladz68 miladz68 requested review from TxCorpi0x, masihyeganeh and ysv and removed request for a team November 17, 2025 10:31
TxCorpi0x
TxCorpi0x previously approved these changes Nov 17, 2025
View reviewed changes

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)

ysv
ysv previously approved these changes Nov 17, 2025
View reviewed changes

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@miladz68 miladz68 dismissed stale reviews from ysv and TxCorpi0x via be63d5b November 17, 2025 16:25
TxCorpi0x
TxCorpi0x approved these changes Nov 18, 2025
View reviewed changes

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

ysv
ysv approved these changes Nov 18, 2025
View reviewed changes

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@miladz68 miladz68 merged commit 7ce0e40 into master Nov 18, 2025
9 checks passed
@miladz68 miladz68 deleted the milad/fix-pse-tests branch November 18, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ysv ysv ysv approved these changes

@masihyeganeh masihyeganeh Awaiting requested review from masihyeganeh masihyeganeh is a code owner automatically assigned from tokenize-x/team-chain

+1 more reviewer

@TxCorpi0x TxCorpi0x TxCorpi0x approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miladz68 @TxCorpi0x @ysv