refactor final score map struct in pse module#24
Conversation
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @ysv)
x/pse/keeper/final_score_map.go line 42 at r1 (raw file):
key, err := m.addressCodec.BytesToString(addr) if err != nil { return
Are we should that BytesToString is always no-error in our case? if yes, i think it would be beneficial to have a wrapper without returned type for address conversion. like MustAccAddressFromBech32 in the prior design.
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @TxCorpi0x)
x/pse/keeper/final_score_map.go line 42 at r1 (raw file):
Previously, TxCorpi0x wrote…
Are we should that
BytesToStringis always no-error in our case? if yes, i think it would be beneficial to have a wrapper without returned type for address conversion. likeMustAccAddressFromBech32in the prior design.
yes
I tend to agree that it doesn't look correct to just return if err is present here
ysv
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @TxCorpi0x)
x/pse/keeper/final_score_map.go line 42 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
yes
I tend to agree that it doesn't look correct to just return if err is present here
blocking
miladz68
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh, @TxCorpi0x, and @ysv)
x/pse/keeper/final_score_map.go line 42 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
blocking
so we should panic instead of returning an error ?
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @ysv)
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @TxCorpi0x)
Description
Reviewers checklist:
Authors checklist
This change is