Skip to content

merge 2 different pse distribution logics#23

Merged
miladz68 merged 5 commits into
masterfrom
milad/unify-pse-distributions
Nov 14, 2025
Merged

merge 2 different pse distribution logics#23
miladz68 merged 5 commits into
masterfrom
milad/unify-pse-distributions

Conversation

@miladz68

@miladz68 miladz68 commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner November 14, 2025 07:09
@miladz68 miladz68 requested review from TxCorpi0x, masihyeganeh and ysv and removed request for a team November 14, 2025 07:09

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need distributeCommunityAllocation? we can use DistributeCommunityPSE directly?

@TxCorpi0x reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)


x/pse/keeper/distribution.go line 210 at r1 (raw file):

// distributeCommunityAllocation handles the distribution logic for Community clearing account.
// Community uses score-based distribution to delegators instead of direct recipient transfers.
func (k Keeper) distributeCommunityAllocation(

nit: why don't we call k.DistributeCommunityPSE directly if these 2 methods are almost same

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @masihyeganeh, @TxCorpi0x, and @ysv)


x/pse/keeper/distribution.go line 210 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

nit: why don't we call k.DistributeCommunityPSE directly if these 2 methods are almost same

Done.
we can use it directly, I will remove the other one.

@miladz68 miladz68 merged commit d3f8e14 into master Nov 14, 2025
8 of 9 checks passed
@miladz68 miladz68 deleted the milad/unify-pse-distributions branch November 14, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants