merge 2 different pse distribution logics#23
Conversation
TxCorpi0x
left a comment
There was a problem hiding this comment.
Do we need distributeCommunityAllocation? we can use DistributeCommunityPSE directly?
@TxCorpi0x reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)
x/pse/keeper/distribution.go line 210 at r1 (raw file):
// distributeCommunityAllocation handles the distribution logic for Community clearing account. // Community uses score-based distribution to delegators instead of direct recipient transfers. func (k Keeper) distributeCommunityAllocation(
nit: why don't we call k.DistributeCommunityPSE directly if these 2 methods are almost same
miladz68
left a comment
There was a problem hiding this comment.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @masihyeganeh, @TxCorpi0x, and @ysv)
x/pse/keeper/distribution.go line 210 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
nit: why don't we call
k.DistributeCommunityPSEdirectly if these 2 methods are almost same
Done.
we can use it directly, I will remove the other one.
Description
Reviewers checklist:
Authors checklist
This change is