added score and delegation time entry to pse genesis#22
Conversation
TxCorpi0x
left a comment
There was a problem hiding this comment.
We need to add missing items for
return &GenesisState{
Params: DefaultParams(),
ScheduledDistributions: []ScheduledDistribution{},
DelegationTimeEntries: ---,
AccountScores: ---,
}
and for
func (m *GenesisState) Validate() error {
exisiting code...
// vlidate delegation time entries
// validate account scores
}
And a bit of comments in proto files
@TxCorpi0x reviewed all commit messages.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)
miladz68
left a comment
There was a problem hiding this comment.
Done.
Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 4 of 6 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)
proto/tx/pse/v1/genesis.proto line 24 at r3 (raw file):
(gogoproto.moretags) = "yaml:\"scheduled_distributions\"" ];
nit: remove whitespaces ?
Code quote:
·
miladz68
left a comment
There was a problem hiding this comment.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)
proto/tx/pse/v1/genesis.proto line 24 at r3 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
nit: remove whitespaces ?
Done.
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x reviewed 2 of 6 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 3 of 3 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x reviewed 3 of 3 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 3 of 3 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
Description
Reviewers checklist:
Authors checklist
This change is