Skip to content

added score and delegation time entry to pse genesis#22

Merged
miladz68 merged 10 commits into
masterfrom
milad/complete-genesis
Nov 18, 2025
Merged

added score and delegation time entry to pse genesis#22
miladz68 merged 10 commits into
masterfrom
milad/complete-genesis

Conversation

@miladz68

@miladz68 miladz68 commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner November 13, 2025 12:06
@miladz68 miladz68 requested review from TxCorpi0x, masihyeganeh and ysv and removed request for a team November 13, 2025 12:06

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add missing items for

return &GenesisState{
    Params:                 DefaultParams(),
    ScheduledDistributions: []ScheduledDistribution{},
    DelegationTimeEntries: ---,
    AccountScores: ---,
}

and for

func (m *GenesisState) Validate() error {
    exisiting code...

  // vlidate delegation time entries
  // validate account scores
}

And a bit of comments in proto files

@TxCorpi0x reviewed all commit messages.
Reviewable status: 0 of 6 files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Reviewable status: 0 of 7 files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)

ysv
ysv previously approved these changes Nov 14, 2025

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 4 of 6 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh)


proto/tx/pse/v1/genesis.proto line 24 at r3 (raw file):

    (gogoproto.moretags) = "yaml:\"scheduled_distributions\""
  ];
  

nit: remove whitespaces ?

Code quote:

·

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)


proto/tx/pse/v1/genesis.proto line 24 at r3 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

nit: remove whitespaces ?

Done.

TxCorpi0x
TxCorpi0x previously approved these changes Nov 17, 2025

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 2 of 6 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

ysv
ysv previously approved these changes Nov 17, 2025

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@miladz68 miladz68 dismissed stale reviews from TxCorpi0x and ysv via 5aa3d21 November 18, 2025 12:04

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)

@miladz68 miladz68 merged commit 72bb1db into master Nov 18, 2025
9 checks passed
@miladz68 miladz68 deleted the milad/complete-genesis branch November 18, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants