Skip to content

fix inflation according pse plan requirements#19

Merged
miladz68 merged 1 commit into
masterfrom
milad/pse-fix-inflation-params
Nov 14, 2025
Merged

fix inflation according pse plan requirements#19
miladz68 merged 1 commit into
masterfrom
milad/pse-fix-inflation-params

Conversation

@miladz68

@miladz68 miladz68 commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Description

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@miladz68 miladz68 requested a review from a team as a code owner November 13, 2025 07:10
@miladz68 miladz68 requested review from TxCorpi0x, masihyeganeh and ysv and removed request for a team November 13, 2025 07:10

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @TxCorpi0x)


app/upgrade/v6/mint_params.go line 15 at r1 (raw file):

		return err
	}
	params.InflationRateChange = math.LegacyMustNewDecFromStr("0.04")

q:
are these values set according to this doc ?
https://docs.google.com/spreadsheets/d/1xZsoYSG-9n9sSVDNY-aaUdWXeZhjZMutCe44192XVSo/edit?gid=961017402#gid=961017402

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TxCorpi0x reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @miladz68)

@miladz68 miladz68 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @ysv)


app/upgrade/v6/mint_params.go line 15 at r1 (raw file):

Previously, ysv (Yaroslav Savchuk) wrote…

q:
are these values set according to this doc ?
https://docs.google.com/spreadsheets/d/1xZsoYSG-9n9sSVDNY-aaUdWXeZhjZMutCe44192XVSo/edit?gid=961017402#gid=961017402

yes they are.

@miladz68 miladz68 merged commit 46e6f8c into master Nov 14, 2025
8 of 9 checks passed
@miladz68 miladz68 deleted the milad/pse-fix-inflation-params branch November 14, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants