added additional test to the pse distribute method#16
Conversation
TxCorpi0x
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @masihyeganeh and @ysv)
x/pse/keeper/distribute_test.go line 136 at r1 (raw file):
func(r *runEnv) { assertScoreResetAction(r) }, }, },
- We can have a test like
test distribution with zero total, all should go to community pool? - As well as
test multiple distributions without delegation changesto get rewards for all periods - Account the undelegated a few of delegations, some of them gone and some of them remain
- Or edge case, account that undelegated right before distribution, (would it be a race condition?
x/pse/keeper/hooks_test.go line 293 at r1 (raw file):
}) r.requireT.NoError(err) r.requireT.Equal(0, count)
This line is checking the count of AccountScoreSnapshot again.
miladz68
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @TxCorpi0x, and @ysv)
x/pse/keeper/distribute_test.go line 136 at r1 (raw file):
Previously, TxCorpi0x wrote…
- We can have a test like
test distribution with zero total, all should go to community pool?- As well as
test multiple distributions without delegation changesto get rewards for all periods- Account the undelegated a few of delegations, some of them gone and some of them remain
- Or edge case, account that undelegated right before distribution, (would it be a race condition?
- Done.
- Done.
- exists
- exists
x/pse/keeper/hooks_test.go line 293 at r1 (raw file):
Previously, TxCorpi0x wrote…
This line is checking the count of AccountScoreSnapshot again.
Done.
TxCorpi0x
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
Description
Reviewers checklist:
Authors checklist
This change is