Skip to content

Fix Randomness in Funding acccounts in integration tests#132

Merged
TxCorpi0x merged 2 commits into
masterfrom
mehdi/fix-randomness-fund-accounts
Apr 24, 2026
Merged

Fix Randomness in Funding acccounts in integration tests#132
TxCorpi0x merged 2 commits into
masterfrom
mehdi/fix-randomness-fund-accounts

Conversation

@TxCorpi0x

@TxCorpi0x TxCorpi0x commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Description

Existing Behavior: each funding request appended a new output directly, so a same address could appear multiple times in msg.Outputs. A practical safeguard is to avoid duplicate recipients in the same multisend batch.

The change: outputs are aggregated by address first, then, if the address repeats, it preserves the uniqueness of the address. if the address repeats, coins are merged with sdk.Coins.Add(...) and final msg.Outputs is built once per unique address.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@TxCorpi0x TxCorpi0x requested a review from a team as a code owner April 23, 2026 15:41
@TxCorpi0x TxCorpi0x requested review from metalarm10 and ysv and removed request for a team April 23, 2026 15:41

@metalarm10 metalarm10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metalarm10 reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ysv).

@TxCorpi0x TxCorpi0x merged commit 4144e6e into master Apr 24, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants