Fix Randomness in Funding acccounts in integration tests#132
Merged
Conversation
metalarm10
approved these changes
Apr 24, 2026
metalarm10
left a comment
Contributor
There was a problem hiding this comment.
@metalarm10 reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ysv).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Existing Behavior: each funding request appended a new output directly, so a same address could appear multiple times in msg.Outputs. A practical safeguard is to avoid duplicate recipients in the same multisend batch.
The change: outputs are aggregated by address first, then, if the address repeats, it preserves the uniqueness of the address. if the address repeats, coins are merged with sdk.Coins.Add(...) and final msg.Outputs is built once per unique address.
Reviewers checklist:
Authors checklist
This change is