Fix Random PSE upgrade Test#131
Conversation
metalarm10
left a comment
There was a problem hiding this comment.
@metalarm10 reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on TxCorpi0x and ysv).
integration-tests/upgrade/pse_test.go line 133 at r1 (raw file):
elapsedMinSec := beforeScoreBlockTimeSec - p.preUpgradeBlockTimeSec elapsedMaxSec := afterScoreBlockTimeSec - p.preUpgradeBlockTimeSec
Should this PR also apply the same pattern to Before(), so the new elapsedMin / elapsedMax properly bracket the pre-upgrade timestamp too?
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on metalarm10 and ysv).
integration-tests/upgrade/pse_test.go line 133 at r1 (raw file):
Previously, metalarm10 wrote…
Should this PR also apply the same pattern to
Before(), so the newelapsedMin/elapsedMaxproperly bracket the pre-upgrade timestamp too?
Please have a look into the recent changes, i think that satisfy your suggestion.
metalarm10
left a comment
There was a problem hiding this comment.
@metalarm10 reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ysv).
Description
Reviewers checklist:
Authors checklist
This change is