Remove Unnecessary Retry from Network testutil#122
Merged
Conversation
metalarm10
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request simplifies the
testutil/network/network.gofile by removing retry logic and related dependencies when creating a new test network. The code now directly creates the network without attempting to handle "address already in use" errors, reflecting a move toward simpler and more deterministic test setup.What cosmos SDK v0.52+ actually did (and v0.53.x has):
In init(), the SDK now pre-allocates a portPool of 200 free TCP ports by calling FreeTCPAddr() for each (bind → get port → release), then uses those ports when creating test validators. This eliminates the race condition entirely — the workaround is no longer needed.
Dependency cleanup:
context,strings, andgithub.com/tokenize-x/tx-tools/pkg/retry. [1] [2]Test setup simplification:
Newwith a direct call tonetwork.New, eliminating the workaround for port conflicts.Reviewers checklist:
Authors checklist
This change is