Skip to content

feat(pse): Split scheduled distributions query into processed and unprocessed endpoints#116

Merged
metalarm10 merged 4 commits into
masterfrom
john/pse-schedule-query-improvement
Apr 2, 2026
Merged

feat(pse): Split scheduled distributions query into processed and unprocessed endpoints#116
metalarm10 merged 4 commits into
masterfrom
john/pse-schedule-query-improvement

Conversation

@metalarm10

@metalarm10 metalarm10 commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Closes: https://app.clickup.com/t/868j3a66m

Description

Adds two new query endpoints for PSE scheduled distributions:

/tx/pse/v1/unprocessed_scheduled_distributions : returns only upcoming (ID > LastProcessedDistributionID)
/tx/pse/v1/processed_scheduled_distributions: returns only completed (ID <= LastProcessedDistributionID)

Both responses include last_processed_distribution_id for context. Existing scheduled_distributions endpoint unchanged.
gRPC query tests added for new endpoints.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@metalarm10 metalarm10 requested a review from a team as a code owner April 2, 2026 08:39
@metalarm10 metalarm10 requested review from TxCorpi0x, masihyeganeh, miladz68 and ysv and removed request for a team April 2, 2026 08:39

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metalarm10 Is the intention to add Unprocessed/Processed as well as existing old (all) query, or we are going to remove it?

@TxCorpi0x made 1 comment.
Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on masihyeganeh, miladz68, and ysv).

@TxCorpi0x TxCorpi0x left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the call, We can keep all of them.

@TxCorpi0x reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on masihyeganeh, miladz68, and ysv).

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 8 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on masihyeganeh and miladz68).

@metalarm10 metalarm10 merged commit bc62a33 into master Apr 2, 2026
14 checks passed
@metalarm10 metalarm10 mentioned this pull request Apr 3, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants