Skip to content

Move MsgSubmitProposal of group module to non-determinstic gas#104

Merged
TxCorpi0x merged 5 commits into
masterfrom
mehdi/group-proposal-withdraw-gas
Mar 16, 2026
Merged

Move MsgSubmitProposal of group module to non-determinstic gas#104
TxCorpi0x merged 5 commits into
masterfrom
mehdi/group-proposal-withdraw-gas

Conversation

@TxCorpi0x

@TxCorpi0x TxCorpi0x commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Description

This pull request updates the deterministic gas configuration for group messages by moving MsgWithdrawProposal from the deterministic to the non-deterministic category. This change ensures more consistent gas estimation logic for proposal-related messages and updates the associated tests to reflect the new categorization.

Changes to gas configuration logic:

  • Removed MsgWithdrawProposal from the deterministic gas mapping in DefaultConfig, so it no longer uses a fixed gas value.
  • Added MsgWithdrawProposal to the list of non-deterministic messages in DefaultConfig, aligning its treatment with other proposal-related messages.

Test updates:

  • Updated TestDeterministicGas_DeterministicMessages to reflect the new counts: increased non-deterministic messages by one and decreased deterministic messages by one.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@TxCorpi0x TxCorpi0x requested a review from a team as a code owner March 11, 2026 16:38
@TxCorpi0x TxCorpi0x requested review from akhlopiachyi, masihyeganeh, metalarm10, miladz68 and ysv and removed request for a team March 11, 2026 16:38

@ysv ysv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysv reviewed 4 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on akhlopiachyi, masihyeganeh, metalarm10, and miladz68).

@metalarm10 metalarm10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@metalarm10 reviewed all commit messages and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on akhlopiachyi, masihyeganeh, and miladz68).

@TxCorpi0x TxCorpi0x merged commit b5c8131 into master Mar 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants