Testnet Missed upgrade steps#102
Conversation
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 8 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on masihyeganeh, metalarm10, miladz68, and TxCorpi0x).
app/app.go line 136 at r1 (raw file):
appupgradev6 "github.com/tokenize-x/tx-chain/v6/app/upgrade/v6" appupgradev6patch1 "github.com/tokenize-x/tx-chain/v6/app/upgrade/v6patch1" appupgradev6patch1testnet "github.com/tokenize-x/tx-chain/v6/app/upgrade/v6patch1testnet"
did I understand correctly that you propose to make everything in a single v6patch1testnet upgrade including denom migrate & testnet fixes ?
app/app.go line 136 at r1 (raw file):
appupgradev6 "github.com/tokenize-x/tx-chain/v6/app/upgrade/v6" appupgradev6patch1 "github.com/tokenize-x/tx-chain/v6/app/upgrade/v6patch1" appupgradev6patch1testnet "github.com/tokenize-x/tx-chain/v6/app/upgrade/v6patch1testnet"
Also, I wish we were able to build binaries with more custom version, smth like v6.1.0-testnet.
Could you pls check if there is a way to add it simply to our CI
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on masihyeganeh, metalarm10, miladz68, and ysv).
app/app.go line 136 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
did I understand correctly that you propose to make everything in a single v6patch1testnet upgrade including denom migrate & testnet fixes ?
Yes, both in the same Upgrade specific for testnet
app/app.go line 136 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
Also, I wish we were able to build binaries with more custom version, smth like
v6.1.0-testnet.
Could you pls check if there is a way to add it simply to our CI
we can change the CI in a way that everything with version v6.1.0-{X} to be created as release version, only the rc suffix to be created as release candidate (e.g.v6.1.0-rc)
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on masihyeganeh, metalarm10, miladz68, and ysv).
app/app.go line 136 at r1 (raw file):
Previously, TxCorpi0x wrote…
we can change the CI in a way that everything with version
v6.1.0-{X}to be created as release version, only thercsuffix to be created as release candidate (e.g.v6.1.0-rc)
Or in other way, any suffix (e.g. alpha, beta, rc, testnet, etc.) to be prerelease, and only clean version (e.g. v1.0.0) to be release.
Currenlty only rc suffix is created as prerelease here.
ysv
left a comment
There was a problem hiding this comment.
@ysv made 1 comment and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on masihyeganeh, metalarm10, and miladz68).
app/app.go line 136 at r1 (raw file):
Previously, TxCorpi0x wrote…
Or in other way, any suffix (e.g. alpha, beta, rc, testnet, etc.) to be prerelease, and only clean version (e.g. v1.0.0) to be release.
Currenlty only rc suffix is created as prerelease here.
I see
resolving it here and lets add this as a separate task
Description
This pull request introduces a patch upgrade for the v6 release, focusing on updating the PSE module parameters to testnet defaults and clarifying which migrations have already been performed in previous upgrades. The upgrade handler is renamed and unnecessary migration steps are commented out to prevent redundancy.
Upgrade handler changes:
"v6"to"v6-params-patch"to reflect its purpose as a patch.StoreUpgradesand migration steps to comment out actions that were already completed in the previous v6.0.0 upgrade, preventing duplicate execution and clarifying upgrade history. [1] [2]PSE module Changes:
TestnetV6Patchfunction inpse_init.goto set PSE module parameters to testnet defaults, and integrated this step into the upgrade handler. [1] [2]Reviewers checklist:
Authors checklist
This change is