update rust to nightly-2021-10-03#2858
Merged
bors[bot] merged 1 commit intotock:masterfrom Oct 11, 2021
Merged
Conversation
Contributor
|
I think it makes sense to update again this month if there is something we want. You need to run the update script though |
bradjc
requested changes
Oct 5, 2021
Contributor
bradjc
left a comment
There was a problem hiding this comment.
Yeah let's update rust whenever we need new features.
But do need to run the script.
6301364 to
a90a308
Compare
Contributor
Author
|
I ran the script, and went with 2021-10-05 because that is what the script suggested |
bradjc
approved these changes
Oct 5, 2021
alistair23
approved these changes
Oct 5, 2021
ppannuto
approved these changes
Oct 6, 2021
Contributor
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates Rust to yesterday's nightly, and adds an
allow()for 14 dead code warnings that surface in the tbf header module.I was motivated to submit this because upstream Rust recently switched over to LLVMs new pass manager (rust-lang/rust#88243) which seems to be able to make better decisions about inlining functions thanks to its bottom-up pass approach ensuring that callees are always maximally optimized by the time callers are being optimized.
This change reduces code size by 1232 bytes on Imix.
I realize that two rust updates in a month is more frequently than we normally update, so if we want to wait a while I understand.
Testing Strategy
This pull request was tested by compiling.
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.