add GLOB for sqlite, duckdb#1067
Conversation
georgesittas
left a comment
There was a problem hiding this comment.
Left a few comments but looks good otherwise. Thanks!
Also, it'd be great to add some more tests.
|
Thanks for that feedback, I've pushed an update. I'm seeing lint failures from black in files that this PR doesn't touch: https://github.com/tobymao/sqlglot/actions/runs/4065549105/jobs/7000406980 - I'm not sure what's going on there. |
Yeah, I had a similar problem in my PR. I locally had black v22.6.0, whereas the github CI seems to be downloading black v23.1.0, which introduced some breaking changes. After the formatting issues are addressed, this is good to go. |
|
Ah, thanks! Should be good now. |
fixes #1066