Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82fd6707e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR narrows the persistent ai-code-auto-test-type modes to only Ask every time (ask-me) and Off (nil), so test/TDD prompting isn’t automatically triggered by default for non-code-change workflows.
Changes:
- Restrict
ai-code-auto-test-typecustomization options and transient menu selection toask-meandnil. - Simplify send-time auto-test type resolution to only operate when persistent mode is
ask-me. - Update ERT tests to reflect the reduced persistent mode surface area.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ai-code.el |
Limits persistent auto-test mode options and updates resolution/menu code accordingly. |
test/test_ai-code.el |
Removes tests for deprecated persistent modes and adds coverage for the new restricted choices. |
|
Both feedbacks addressed. |
Using this feature for more than 1 month. I don't feel it is necessary to always auto trigger test or TDD. Things such as ask a question about code, or edit document, has no need to trigger them.