Chore: Size side windows by body width and add test#273
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates side-window sizing to target a configured body width (rather than total window width) and adds a regression test to validate the behavior.
Changes:
- Switches side-window
window-widthsizing from a fixed integer to a helper intended to fit the window’s body width. - Updates
ai-code-backends-infra-window-widthdocstring to clarify it represents body width. - Adds an ERT test covering the new side-window body-width sizing behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ai-code-backends-infra.el |
Adjusts side-window display rules to size by body width via a helper function. |
test/test_ai-code-backends-infra.el |
Adds a test intended to assert body-width-based sizing for horizontal side windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.