Skip to content

Conversation

@tony
Copy link
Member

@tony tony commented Mar 19, 2022

All documentation configurations in examples/ must work.

  • refactor(test): load_fixture -> read_config_file

    less ambiguity

  • tests/__init__.py: Move constants to tests/constants.py

  • test util functions: use namespaced modules

    e.g. read_config_file() -> test_utils.read_config_file()

  • test/_util.py -> test/utils.py

@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #761 (ccec7fc) into master (abf7a32) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   76.21%   76.21%           
=======================================
  Files           7        7           
  Lines        1194     1194           
  Branches      314      314           
=======================================
  Hits          910      910           
  Misses        196      196           
  Partials       88       88           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abf7a32...ccec7fc. Read the comment docs.

@tony tony merged commit 4a4ff08 into master Mar 20, 2022
@tony tony deleted the test-examples branch March 20, 2022 13:01
@tony tony changed the title Test all examples/ Refactor tests/ fixture access Mar 20, 2022
@tony tony changed the title Refactor tests/ fixture access Refactor tests/ fixture and constants access Mar 20, 2022
@tony tony mentioned this pull request Mar 20, 2022
3 tasks
@tony tony added this to the Milestone 1.11 milestone Mar 20, 2022
@tony tony self-assigned this Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants