Append test plugin packages via monkeypatch.syspath_prepend
#666
+50
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-flinn
approved these changes
Feb 3, 2021
Contributor
joseph-flinn
left a comment
There was a problem hiding this comment.
@tony I like this approach much better than what I had. Testing is probably my weakest technical skill and monkeypatch is still a pretty big black box to me.
Member
Author
|
@joseph-flinn Then let's give this a shot! I will backport and publish versions for 1.6 and 1.7 to see if that works for #658 (and any other maintainers that bumped into this issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658
1st commit : Applies monkey patch globally to all tests, removes test packages from
pyproject.toml2nd commit : Scopes it to only relevant packages, so unrelated tests don't have
sys.path's altered.This is optional, but good to ensure explicitness (down the road, implicit alteration of site packages for all tests may be super hard to track down if it leads to an error in tests years from now, so I try to use
autouse=Truesparingly as possible)Any thoughts on this approach @joseph-flinn?