-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add F1 help key binding to choose modes #4751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add F1 help key binding to choose modes #4751
Conversation
|
Thanks:
|
|
I can add those. Thanks for the review! |
|
Are you still working on this? |
Screen.Recording.2026-01-05.at.11.13.33.PM.mov |
Add F1 key binding to display a help menu showing available key bindings in choose modes (choose-tree, choose-buffer, choose-client, customize-mode). The help menu displays all common key bindings for navigation, selection, tagging, searching, and sorting, making it easier to discover available functionality without consulting the manual. Fixes tmux#4357
5d7b0fb to
c807f69
Compare
|
Sorry for the delay. Let me know if this is what you had in mind. |
|
|
Thanks. I actually liked the menu, it just needed to execute the command when you chose it :-). But a popup is OK instead, but we can't run Please take a look at this which adds a way to directly write into a popup: help.diff.txt I also added some formatting to the text. The only problem now is that this is only the common keys, it doesn't include stuff like I don't see any need to get complicated and try to merge common and individual mode help, I think we just copy the common keys into each one. |
|
Did you get a chance to look at my changes? Do you want to work on this further or shall I do it? |
|
I can get this over the finish line. My availability comes in small batches. I'll take look at the code you shared. I can update it to be an interactive menu that executes selected commands. |
|
Good stuff, thanks. I don't mind if it is a menu or a popup, I think it looks OK as a popup the way I have it. But it should include the commands that are special to each mode. |
Problem
Users find it difficult to discover key bindings for choose modes (choose-tree, choose-buffer, choose-client, customize-mode) without consulting the manual.
Fixes #4357
Solution
Add an F1 key binding that displays a help menu showing all available key bindings in choose modes. The menu lists navigation, selection, tagging, searching, and sorting keys.
Key Choice
F1 was chosen because the more intuitive alternatives are already in use:
h- Used for collapse/left navigation (same as Left arrow)?- Used for forward search (same as/)H- Used in window-tree.c to jump to the current pane ("Home")F1 is a conventional help key that doesn't conflict with existing bindings.
Testing
tmux new-sessionCtrl+b wF1to see the help menuqorEscapeto close the help menu