Add support for spawning panes in separate cgroups#3514
Closed
yut23 wants to merge 3 commits intotmux:masterfrom
Closed
Add support for spawning panes in separate cgroups#3514yut23 wants to merge 3 commits intotmux:masterfrom
yut23 wants to merge 3 commits intotmux:masterfrom
Conversation
Member
|
This looks fine, thanks. Not a fan of shipping extra config files. I'd just turn it on by default if it's something most people are likely to want. Or add a configure flag. I don't think it needs runtime config. |
This can occur if the child process exits before the dbus call in the parent finishes, in which case the cgroup is unneeded.
Member
|
I can't confirm if the systemd bits work but it all looks good to me. Applied now with one minor fix (free *cause in spawn.c on failure) and some minor style nits (spacing and tidy comments). Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves newly-spawned panes into their own cgroups via transient systemd transient scopes, as discussed in #3024 and #3183. It uses the dbus API provided by libsystemd, so no new libraries are needed.
Some questions that need to be addressed before merging:
CollectMode=inactive-or-failedin/usr/lib/systemd/user/vte-spawn-.scope.d/defaults.conf). We could set that option directly in the dbus call, but putting it in a config file lets the end users/packagers override it if they want to inspect any errors. Do we want to include such a file with tmux?