Merged
Conversation
Lustyn
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prepare for the upcoming certmagic update in Casket, this PR updates all of the DNS providers to use libdns instead of lego, where possible. While it is technically possible to write a wrapper for lego, I thought it would be better to switch to what certmagic actually supports, and reduce our maintenance footprint too.
Over half of the DNS providers were removed, and some configuration options have changed. This is definitely a breaking change. I'm not sure how many people outside of tmpim use Casket, so we will need to clearly communicate the breaking changes, and invite issues/pull requests for providers that libdns doesn't support. Worst case, we can write a lego wrapper. I have documented the changes to the DNS providers and their configuration here, which can be included in the release notes when the time comes.
This change also supports block configuration for all of the DNS providers, which allows us to account for the only change we made in DNS providers - supporting more than one configuration/key per each type of provider. Environment variable expansion should still work in these block configurations. An example configuration for the cloudflare provider would look like this:
This PR depends on changes in Casket (tmpim/casket#29), but this one will need to be merged first. I will also update the casket-docs for every provider.