This repository was archived by the owner on Feb 24, 2026. It is now read-only.
feat: use arm64 instances for arm64 platform builds#32
Merged
tmokmss merged 3 commits intotmokmss:mainfrom Apr 12, 2025
Merged
Conversation
Contributor
Author
|
スナップショットテストの変更については、マージ後に対応する予定です。現在の変更は意図的なものであり、インフラリソースの変更により既存のスナップショットテストとの不一致が発生しています。 |
Contributor
Author
|
The snapshot test changes will be addressed after merging. The current changes are intentional, and the discrepancy with existing snapshot tests is due to infrastructure resource changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements issue #31. It adds support for using ARM64 instances when building container images for ARM64 platform.
Changes
propsToAdditionalStringmethod inSingletonProjectclass to include platform information (amd64/arm64) in the slugcontainer-image-build.tsto select the appropriate build image based on the target platform:LinuxArmBuildImagefor ARM64 buildsLinuxBuildImagefor AMD64 buildsprojectPurposenames for ARM64 build projectsThis change improves build performance for ARM64 platform images by utilizing native ARM64 build environments.
Breaking Changes
This PR contains intentional breaking changes. It replaces existing project resources by creating separate CodeBuild projects per platform. This causes snapshot tests to fail, but it's the expected behavior. The snapshot tests will need to be updated.
Closes #31