client: secure now defaults to true (fixes #394) #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlcaDesign
requested changes
Jul 16, 2020
Member
AlcaDesign
left a comment
There was a problem hiding this comment.
I would prefer to set secure to true by default only if the server and port options are also default values. This would need to be checked within client.prototype.connect.
Contributor
Author
|
@AlcaDesign change made |
AlcaDesign
approved these changes
Jul 16, 2020
|
Doesn't that mean that if you set the port to 443, it would default to insecure again? Users should have to go out of their way to turn off security. |
Contributor
Author
|
Connect() will set secure to true when the port is 443
https://github.com/tmijs/tmi.js/blob/df228dc818dbfe203bf85d19c54e7be1e6177077/lib/client.js#L1061-L1063
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Meerkov proposed this change in #395 but that PR went stale
I changed the commit message as requested
Closes #395
Fixes #394