fix: HSTS header case issue with HTTP/2#83
Merged
ic0ns merged 1 commit intotls-attacker:masterfrom Jun 21, 2022
Merged
Conversation
HTTP/2 headers are lower-case
|
Can one of the admins verify this patch? |
ic0ns
approved these changes
Jun 21, 2022
Contributor
|
Ah thats good to know. I wasn't aware that h2 changed this, and only took the header from the RFC6797. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP/2 headers are lower-case.
When scanning www.bundestag.de the tool reports:
"HSTS is disabled. Enable HSTS"
However, the header is set:
$ curl -s https://www.bundestag.de -D - | grep strict-transport-security strict-transport-security: max-age=31536000This patch fixes it. There might be a lot more issues like this in the code, however...