improvement(editor): style links in error fallback#4932
Merged
steveruizok merged 5 commits intotldraw:mainfrom Nov 19, 2024
Merged
improvement(editor): style links in error fallback#4932steveruizok merged 5 commits intotldraw:mainfrom
steveruizok merged 5 commits intotldraw:mainfrom
Conversation
|
@nayounsang is attempting to deploy a commit to the tldraw Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Why did unexpected modifications occur with the |
e2f61c4 to
4a0bd37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added blue underline style to links in error messages to improve visibility in the error fallback component.
Change type
improvementTest plan
Release notes
close #4927
Currently, tldraw seems to be styling with CSS. If it's good, I'll add a style for that function in css.
If so, more styles can be applied.
For ex...(There are concerns that writing this as style props may reduce readability.)