Skip to content

improvement(editor): style links in error fallback#4932

Merged
steveruizok merged 5 commits intotldraw:mainfrom
nayounsang:error-link-blue
Nov 19, 2024
Merged

improvement(editor): style links in error fallback#4932
steveruizok merged 5 commits intotldraw:mainfrom
nayounsang:error-link-blue

Conversation

@nayounsang
Copy link
Contributor

@nayounsang nayounsang commented Nov 18, 2024

Added blue underline style to links in error messages to improve visibility in the error fallback component.

Change type

  • improvement

Test plan

  1. Trigger an error in the editor to show the DefaultErrorFallback.
  2. Verify the "create a GitHub issue" link is blue and underlined.
  • Unit tests
  • End to end tests

Release notes

  • Added styling for links in the error fallback component.

close #4927

image

<a href={url.toString()} style={{ color: 'blue', textDecoration: 'underline' }}>
	create a GitHub issue
</a>

Currently, tldraw seems to be styling with CSS. If it's good, I'll add a style for that function in css.
If so, more styles can be applied.
For ex...(There are concerns that writing this as style props may reduce readability.)

a {
  color: #0000ee; 
  text-decoration: underline; 
  cursor: pointer; 
}

a:visited {
  color: #551a8b; 
}

a:hover {
  color: #0000cc; 
  text-decoration: underline; 
}

a:active {
  color: #ff0000; 
}

@huppy-bot huppy-bot bot added feature New feature improvement Product improvement labels Nov 18, 2024
@vercel
Copy link

vercel bot commented Nov 18, 2024

@nayounsang is attempting to deploy a commit to the tldraw Team on Vercel.

A member of the Team first needs to authorize it.

@nayounsang
Copy link
Contributor Author

Why did unexpected modifications occur with the lint and format commands? I will reflect this later.

@steveruizok steveruizok added this pull request to the merge queue Nov 19, 2024
Merged via the queue into tldraw:main with commit 4b94c10 Nov 19, 2024
@steveruizok steveruizok added the sdk Affects the tldraw sdk label Jan 2, 2026
@steveruizok steveruizok changed the title Error link blue improvement(editor): style links in error fallback Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature improvement Product improvement sdk Affects the tldraw sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error message links should be colored blue.

2 participants