refactor(editor): specify type for bbox in getSvgJsx#4732
Merged
steveruizok merged 1 commit intotldraw:mainfrom Oct 19, 2024
Merged
refactor(editor): specify type for bbox in getSvgJsx#4732steveruizok merged 1 commit intotldraw:mainfrom
steveruizok merged 1 commit intotldraw:mainfrom
Conversation
|
@nayounsang is attempting to deploy a commit to the tldraw Team on Vercel. A member of the Team first needs to authorize it. |
steveruizok
approved these changes
Oct 19, 2024
Collaborator
|
Thanks @nayounsang ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that bbox's type is any. Bbox is a let variable, so I thought it would be good to improve.
Change type
improvementTest plan
Just I change the type, so logic is not changed. It just checks to see if there are any type errors.
Unit tests
End to end tests
Release notes