Resolve Undefined Flags Issue in slp diff Command#12
Merged
tkuchiki merged 2 commits intotkuchiki:mainfrom Dec 4, 2023
Merged
Conversation
Owner
|
@shima004 Thank you for fixing the issue, and I'm sorry for the late response. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
slp diffcommand was throwing an error due to the undefined flags.Description
go run ./cmd/slp/main.go diff ./example/slp-dump-1.yaml ./example/slp-dump-2.yaml 2023/11/21 19:49:16 flag accessed but not defined: sort exit status 1Solution
Result
Note to Reviewers
I haven't submitted many pull requests, so if there are any areas that need improvement or if I overlooked something, your feedback would be greatly appreciated. Thank you!