Changed how the Electron framework version is detected: #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• The `strings` command is only available when Xcode is installed - this prevents normal folks from using the script • Extracting the version from the framework's Info.plist is faster
Contributor
Author
|
I needed this tool for customer support and most customers don't have Xcode installed 😉 |
Contributor
Author
|
I probably messed up the indentation, too. I use tabs and this script does not. |
Owner
|
@chockenberry Hi Craig, sorry I missed your contribution (gotta turn the notification emails on)! Merged, and updated also in https://gist.github.com/tkafka/e3eb63a5ec448e9be6701bfd1f1b1e58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• The
stringscommand is only available when Xcode is installed - this prevents normal folks from using the script• Extracting the version from the framework's Info.plist is faster