-
Notifications
You must be signed in to change notification settings - Fork 1.2k
DATA LOSS! Major bug in git-delete-submodule #799
Copy link
Copy link
Closed
Description
git-extras/bin/git-delete-submodule
Line 24 in a6a1754
| rm -rf ".git/modules/$NAME" |
This is fundamentally incompatible to the --name option of git submodule add.
Consider
git submodule add --name one ./ two
git submodule add --name two ./ one
git delete-submodule one
or
git submodule add ./ one
git mv one two
git submodule add --name anotherone ./ one
git delete-submodule one
And no, this is not an academical problem.
Recommendation:
Remove this line, as removing something below .git/modules/ can be considered harmful to the history and git bisect.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels