Conversation
bad7cd6 to
7bfb277
Compare
|
I do not see I do see some odd test failures using Node v18.17.0 on Mac, and in the Jest tests being run automatically in the VSCode editor. I'll add a comment in the linked issue. I don't think is a problem that needs to be solved in Commander though. |
However, I am glad to know about the issue before stumbling across it myself! 😅 |
Was supposed to be a temporary fix, but I guess I will just use |
ab92568 to
95a5d50
Compare
95a5d50 to
98fb3cc
Compare
|
Force pushed to make merges less cluttered in case the PR does end up considered useful. |
|
If the PR GitHub Checks start failing or other developers trip over this then will do something, but currently passing and hopefully gets fixed in Jest. For readers, temporary developer work-around to run tests is use |
|
I don't like patching the code with detailed work-around for But perhaps modifying the Jest call in the run-script to use (I am currently running at the previous node to avoid the problem!) |
For me, it has, but the feature is still experimental, so still not sure it should be relied on in general. |
|
Would be temporary, but good point, no need to use experimental. Tests with |
It's 50 vs 20 seconds on mine 🤨 |
Tests of
nodechild processes stopped working on Windows after upgrading to Node.js v18.17.0. The reason turned out to be the fact Jest allows an internally set value of theFORCE_COLORenvironment variable to leak through to tests, see jestjs/jest#14391. This results in colored output of the child processes, and so comparisons of the output with expected values fail.This PR is a quick fix unsetting the variable for the child processes.