Correctly handle allowUnknownOption in .parseOptions()#1946
Closed
aweebit wants to merge 5 commits intotj:release/12.xfrom
Closed
Correctly handle allowUnknownOption in .parseOptions()#1946aweebit wants to merge 5 commits intotj:release/12.xfrom
allowUnknownOption in .parseOptions()#1946aweebit wants to merge 5 commits intotj:release/12.xfrom
Conversation
Export check to variable for clarity and potential future uses
Collaborator
|
The current behaviour is as intended. See longer explanation of |
This was referenced Aug 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#1945
Solution
Implement the first solution suggested in the issue.
Unknown options are now treated as command-arguments in
.parseOptions()as suggested by the docs.The incorrect test has been removed.
ChangeLog
Fixed
.parseOptions()as suggested by the docs