Handle falsy values in addHelpCommand() properly#1927
Closed
aweebit wants to merge 1 commit intotj:developfrom
Closed
Handle falsy values in addHelpCommand() properly#1927aweebit wants to merge 1 commit intotj:developfrom
addHelpCommand() properly#1927aweebit wants to merge 1 commit intotj:developfrom
Conversation
Collaborator
|
The (I would normally leave this open for discussion, but you are have opened ~15 Pull Requests in the last week with ~160 comments between us. I don't have the time to continue that level of feedback.) |
This was referenced Aug 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #1926 for better separation of concerns.
Problem
Only
falseis treated as falsy inaddHelpCommand().ChangeLog
Fixed
.addHelpCommand()