Closed
Conversation
This was referenced Dec 2, 2020
Contributor
|
Better to start using |
Collaborator
Author
|
Hmm, interesting feedback @cravler , thanks! I have been putting off actually changing the defaults. I'll think about that. |
Collaborator
Author
|
On hold, looking at changing default behaviour: #1409 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
We are slow to adopt new best practices which break backwards compatibility. However, it isn't easy for new programs to start with best practices. Likewise it is not easy to switch existing programs to follow what we consider current best practices as they are now and change in future.
We get weak typings in TypeScript because the Command object may have options stored as properties, meaning TypeScript is not able to warn about typos etc.
The big example of a new best practice is
.storeOptionsAsProperties(false).Solution
Add a CommandStrict class. The implementation sets our best practice configuration. The TypeScript typings do not include options as properties.
In the future this class might also error if deprecated code is used, but not looking at that now.
Alternatives considered: I did try adding a
.strict()method in an earlier attempted solution, but that did not help with the TypeScript typings.