Merged
Conversation
added 11 commits
December 2, 2019 17:35
mcred
reviewed
Dec 11, 2019
mcred
approved these changes
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adds the ability to manage different contexts (most notably k8s and docker) in the CLI. This is a big change, and requires some corresponding changes in titan-server that have not yet been merged (namely inheriting the identity in the docker plugin name). Contexts are now
managed locally in
~/.titan/config(which could be used for other things in the future).The basic thrust of the work is to add a new
titan contextcommand that can be used to manage multiple contexts. Other changes were necessary to enable this, including launching local contexts with unique identities.Testing
Ran maven tests, end2end tests (including new multi-context tests) using native image.