Merged
Conversation
mcred
approved these changes
Nov 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
We should have consistent formatting for our kotlin files. This PR adds ktlint, similar to titan-server, but through a maven plugin. To minimize the amount of disruption, I opted for the default of "auto-format on build". This means that every time you run 'mvn install', it will also format your code. That way we're always keeping stuff up to date. It does mean you can technically push badly formatted code (because it auto-fix it and not report an error), but for now this is sufficient. If this becomes a problem, we could alter the PR check to run check separately without formatting.
There are no logic changes in this PR.
Testing
mvn install. Ran getting started e2e tests.