Github Actions with minor fixes#11
Merged
eschrock merged 10 commits intotitan-data:masterfrom Sep 23, 2019
Merged
Conversation
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Signed-off-by: Derek Smart <derek.smart@delphix.com>
Initial OSS Release (#1)
eschrock
approved these changes
Sep 23, 2019
Contributor
eschrock
left a comment
There was a problem hiding this comment.
Make sure to restore windows tests when adding windows support back in.
mcred
referenced
this pull request
in mcred/titan
Sep 24, 2019
Github Actions with minor fixes (#11)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues Addressed
Fixes #6
Windows unit tests fail when testing for line breaks.
Run fails if the docker container is not already pulled.
Proposed Changes
Rather than use
\nas a new lineSystem.lineSeparator()is used.Pulls container during
runto make sure it's local before trying to inspect.Testing
Migrate a container and inspect the volumes. The first one will start with v0 and increment up.
Run the unit test in windows to see the line break fixes.
runa new repo that you do not have locally.