add port metadata even if disablePortMapping set#109
Merged
mcred merged 1 commit intotitan-data:masterfrom Nov 24, 2019
Merged
Conversation
mcred
approved these changes
Nov 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The latest changes for
disablePortMappingare a bit too aggressive in how they manage the port metadata. We want that flag to only control whether ports are mapped when we run the container, not whether they're persisted in the metadata. That way, a later clone can choose to forward those ports if it so desires.Testing
Launched a container with
--disabplePortMapping. Verified that ports were not mapped, but also that ports were present in the repo metadata.