fix(shortcut): prevent in-app shortcuts from being registered globally#999
Merged
fix(shortcut): prevent in-app shortcuts from being registered globally#999
Conversation
Previously, some shortcuts intended for in-app use were incorrectly registered as system-wide hotkeys. This could lead to conflicts with other applications or system functions. This commit refactors the shortcut management logic to clearly differentiate between global and in-app shortcuts. An explicit `globalActions` list has been introduced to define which actions should have global hotkeys. The binding function now verifies an action against this list before registering it with the `HotKeyCenter`, ensuring only designated shortcuts are active system-wide.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where in-app shortcuts were incorrectly registered as system-wide hotkeys, causing conflicts with other applications. The solution introduces a clear distinction between global and in-app shortcuts through an explicit globalActions list and updated binding logic.
- Introduced a
globalActionslist to define which shortcuts should be registered globally - Renamed
bindingShortcutActiontobindingGlobalShortcutActionfor clarity - Added validation to ensure only designated actions are registered as system-wide hotkeys
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ShortcutManager.swift | Added globalActions list defining which shortcuts should be global |
| ShortcutManager+Default.swift | Updated method name and added validation logic to prevent non-global shortcuts from registering system-wide |
| KeyHolderWrapper.swift | Updated method calls to use the renamed bindingGlobalShortcutAction method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tisfeng
commented
Sep 28, 2025
AkaShark
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, some shortcuts intended for in-app use were incorrectly registered as system-wide hotkeys. This could lead to conflicts with other applications or system functions.
This commit refactors the shortcut management logic to clearly differentiate between global and in-app shortcuts. An explicit
globalActionslist has been introduced to define which actions should have global hotkeys. The binding function now verifies an action against this list before registering it with theHotKeyCenter, ensuring only designated shortcuts are active system-wide.Bug introduced in #953
Fix #997 , #992 , #982