fix: accent preference wasn't applied when playing translated English text#916
Merged
fix: accent preference wasn't applied when playing translated English text#916
Conversation
… applied when playing translated English text.
Previously, when playing translated text in the results view, if the target language was English, the system would ignore your British/American accent preference selected in settings. This resulted in American English being played by default.
This update ensures that in EZWordResultView.m, when playing text translated into English, your stored accent setting ("us" or "uk") is read and correctly passed as an accent parameter to the audio playback service.
This resolves the problem you reported in GitHub issue #897, allowing your British/American pronunciation choice to take effect when playing translated results.
Closed
Owner
Author
|
This PR is submitted by Google jules Just a test, but looks good 🙂 |
phlpsong
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a fix for the issue where your chosen accent preference wasn't applied when playing translated English text.
Previously, when playing translated text in the results view, if the target language was English, the system would ignore your British/American accent preference selected in settings. This resulted in American English being played by default.
This update ensures that in EZWordResultView.m, when playing text translated into English, your stored accent setting ("us" or "uk") is read and correctly passed as an accent parameter to the audio playback service.
This resolves the problem you reported in GitHub issue #897 (comment) allowing your British/American pronunciation choice to take effect when playing translated results.