Skip to content

feat: update supported translation types for Caiyun Service#907

Merged
tisfeng merged 8 commits intotisfeng:devfrom
tssujt:caiyun
Jun 9, 2025
Merged

feat: update supported translation types for Caiyun Service#907
tisfeng merged 8 commits intotisfeng:devfrom
tssujt:caiyun

Conversation

@tssujt
Copy link
Copy Markdown
Contributor

@tssujt tssujt commented May 23, 2025

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello tssujt, Thank you for your first PR contribution 🎉 tssujt

@tisfeng
Copy link
Copy Markdown
Owner

tisfeng commented May 30, 2025

Thanks your PR

@tisfeng tisfeng requested review from Jerry23011 and phlpsong May 30, 2025 12:32
@tssujt tssujt requested a review from Jerry23011 May 30, 2025 15:33
@phlpsong phlpsong changed the base branch from main to dev May 31, 2025 00:47
@Jerry23011
Copy link
Copy Markdown
Collaborator

@tssujt You can test all other languages from German.

I know it's tedious, so feel free to request for review after resolving the three conversations above: We can merge this PR and I'll continue from here. Thanks!

@tisfeng
Copy link
Copy Markdown
Owner

tisfeng commented Jun 6, 2025

I used a simple translation example test and found that the Caiyun API seems to support translation between all the languages it supports, except that it cannot translate into the same language.

I have already updated the code logic, please check.

@tisfeng tisfeng requested a review from Jerry23011 June 6, 2025 15:40
Copy link
Copy Markdown
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisfeng tisfeng merged commit 1f28716 into tisfeng:dev Jun 9, 2025
4 checks passed
@tssujt tssujt deleted the caiyun branch June 9, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants