fix(event-monitor): scope high-frequency monitors to pop button#1128
Merged
fix(event-monitor): scope high-frequency monitors to pop button#1128
Conversation
Limit mouse-moved and scroll-wheel monitoring to the pop button visibility lifecycle instead of keeping them active all the time. Also clean up screenshot state monitors during reset, deinit, and overlay teardown to prevent long-lived local monitor leaks.
Owner
Author
|
This is a supplement to #1118 |
This was referenced Mar 29, 2026
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the event monitoring system, particularly for handling high-frequency events (like mouse movement and scrolling) only when necessary, and refines screenshot overlay state management for better resource cleanup. It also updates documentation to clarify AI-assisted development practices.
Event Monitoring Enhancements:
highFrequencyEventMonitorEngineinEventMonitorto monitor high-frequency events (mouseMoved,scrollWheel) only while the pop button is visible, reducing unnecessary CPU usage. This includes new methodsstartHighFrequencyEventMonitorandstopHighFrequencyEventMonitor, and a specialized event handler. [1] [2] [3] [4] [5] [6] [7]addBothMonitorto conditionally start/stop high-frequency monitoring based on theisAutoSelectTextEnabledflag and pop button visibility. [1] [2]stopmethod.Screenshot Overlay State Management:
Screenshotby introducingtearDownOverlayStates, which calls a newcleanupmethod on eachScreenshotStateto ensure local event monitors are removed and resources are released. [1] [2] [3] [4] [5] [6]Documentation Updates:
README.mdandREADME_ZH.mdto recommend using the latest AI models (such asGPT-5.4) for codebase exploration and patch generation, and added guidelines for reviewing AI-generated changes. [1] [2]AGENTS.md.