Fix: query icon flashes when using shortcut translation#1095
Merged
tisfeng merged 4 commits intotisfeng:devfrom Feb 6, 2026
Merged
Fix: query icon flashes when using shortcut translation#1095tisfeng merged 4 commits intotisfeng:devfrom
tisfeng merged 4 commits intotisfeng:devfrom
Conversation
Owner
|
Thanks your PR, looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query icon flashes briefly when triggering a translation via shortcut, even when the "Auto show query icon after selecting text" setting is turned off.
I compared the current code with the v2.16.2. I found that the Swift refactor changed the logic gate in handleSelectedText to a loose || check. This causes shortcut actions to bypass user preferences and incorrectly trigger the query icon to flash.
Changes: Restricted the query icon to auto-selection (.autoSelectQuery) only, aligning it with the logic used in v2.16.2.
Fixes #1088