Skip to content

feat(selection): add conditional triggers for auto show query icon #1084#1085

Merged
tisfeng merged 6 commits intodevfrom
feat/select-text-condition-2
Feb 3, 2026
Merged

feat(selection): add conditional triggers for auto show query icon #1084#1085
tisfeng merged 6 commits intodevfrom
feat/select-text-condition-2

Conversation

@tisfeng
Copy link
Copy Markdown
Owner

@tisfeng tisfeng commented Feb 2, 2026

Add configurable conditions to control when the query icon appears after text selection:

  • Language-based filtering: only show when selected text language differs from excluded language
  • Minimum character length requirement: customizable threshold (0-50 characters) to reduce accidental triggers
  • Settings UI in Advanced tab to configure both conditions

The query icon now respects these conditions to provide more precise control over auto-selection behavior.
image

Close #735

Add configurable conditions to control when the query icon appears after text selection:

- Language-based filtering: only show when selected text language differs from excluded language
- Minimum character length requirement: customizable threshold (0-50 characters) to reduce accidental triggers
- Settings UI in Advanced tab to configure both conditions

The query icon now respects these conditions to provide more precise control over auto-selection behavior.
This commit removes the adjustPopButtonOrigin feature from the app.

The following changes were made:
- Removed the adjustPopButtonOrigin key from Defaults.Keys+Extension.swift
- Removed adjustPopButtomOrigin property from MyConfiguration.swift
- Removed the toggle switch from AdvancedTab.swift settings UI
- Removed related conditional logic in EZWindowManager.m
- Cleaned up localization strings in Localizable.xcstrings
This commit updates the default value for autoShowQueryIconMinTextLength from 20 to 0.

The change makes the auto show query icon feature more accessible by allowing it to appear immediately for any text length when enabled, rather than requiring a minimum of 20 characters.
This commit updates SwiftFormat from version 0.58.7 to 0.59.1, bringing the latest code formatting improvements and bug fixes to the project.

Changes made:
- Update SwiftFormat dependency in Package.swift
- Update resolved package version in Package.resolved
This commit applies SwiftFormat 0.59.1 to automatically format Swift code according to project standards.

Changes include:
- Reorder property declarations for better organization
- Add appropriate spacing and blank lines
- Improve code structure and readability
- Apply consistent formatting patterns across multiple SwiftUI views

No functional changes were made, only code formatting improvements.
@tisfeng tisfeng requested a review from Jerry23011 February 3, 2026 07:05
Copy link
Copy Markdown
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisfeng tisfeng merged commit aae1dc9 into dev Feb 3, 2026
3 checks passed
@tisfeng tisfeng deleted the feat/select-text-condition-2 branch February 3, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 功能建议:不自动对中文取词翻译

2 participants