fix: remove macOS Icon file that breaks Windows compatibility#1070
Merged
tisfeng merged 2 commits intotisfeng:devfrom Feb 4, 2026
Merged
fix: remove macOS Icon file that breaks Windows compatibility#1070tisfeng merged 2 commits intotisfeng:devfrom
tisfeng merged 2 commits intotisfeng:devfrom
Conversation
The `Icon\r` file is a macOS Finder custom icon file that contains a
carriage return character in its filename. This character is invalid
on Windows, causing `git clone` and `git reset` to fail with:
error: invalid path 'Icon?'
Owner
|
Thanks your PR, looks good |
tisfeng
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Icon\rfile is a macOS Finder custom icon file that contains a carriage return character in its filename. This character is invalid on Windows, causinggit cloneandgit resetto fail with: