Fix crash caused by GoogleService#1067
Merged
tisfeng merged 1 commit intotisfeng:devfrom Jan 24, 2026
Merged
Conversation
…p checks `queryModel` in `GoogleService` is an implicitly unwrapped optional and can be `nil`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on testing, setting General > Query Language > Language Detection to "Use Google language detection for optimization" causes a crash, which can be reproduced in both development and release builds. The error is
Easydict/GoogleService+Translate.swift:220: Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value.This is caused by
queryModelinGoogleService, which is an implicitly unwrapped optional. While it is typically set during the main translation flow (startQuery), it is not set (isnil) during standalone language detection (detectText->webAppDetect).Related Issues: