fix(event-monitor): resolve click query interception issue#1059
Merged
Conversation
This commit fixes the issue where click queries were being intercepted prematurely by the local event listener's leftMouseDown handler. The problem was that the leftMouseDown event was always triggering the pop button dismissal logic before the click action could be processed, preventing valid click queries from working. The fix adds a check to skip dismissal when the mouse click occurs within the pop button window itself, allowing the pop button's click action to fire properly before any dismissal logic runs. This ensures that click queries work correctly while maintaining the pop button functionality.
…loating window This commit improves the user experience when clicking the pop button by ensuring the pop button window closes immediately before showing the floating window. The change moves the `[self.popButtonWindow close]` call to the beginning of the `popButtonWindowClicked` method, before any other logic runs. This ensures: 1. The pop button window closes immediately on click 2. The floating window appears without visual interference from the closing pop button 3. Smoother transition between clicking the pop button and seeing the query results Previously, the pop button window was closed at the end of the method, which could cause visual artifacts or delays in the UI transition.
This was referenced Jan 17, 2026
Owner
Author
|
please review |
Jerry23011
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue where click queries were being intercepted prematurely by the local event listener's leftMouseDown handler.
The problem was that the leftMouseDown event was always triggering the pop button dismissal logic before the click action could be processed, preventing valid click queries from working.
The fix adds a check to skip dismissal when the mouse click occurs within the pop button window itself, allowing the pop button's click action to fire properly before any dismissal logic runs.
This ensures that click queries work correctly while maintaining the pop button functionality.
Fix #1053