Skip to content

TINY-10384: Make sure cursor moves to next line when around a <br>, <img>, or <table>#9654

Merged
danoaky-tiny merged 7 commits intomainfrom
feature/TINY-10384
May 23, 2024
Merged

TINY-10384: Make sure cursor moves to next line when around a <br>, <img>, or <table>#9654
danoaky-tiny merged 7 commits intomainfrom
feature/TINY-10384

Conversation

@danoaky-tiny
Copy link
Copy Markdown
Contributor

@danoaky-tiny danoaky-tiny commented May 17, 2024

Related Ticket: TINY-10384

Description of Changes:

  • Added a check before the cursor is potentially moved by the insertBefore function, to make sure it moves to the next line.
  • Added NewlineAroundBrTest.ts and modified existing EnterKeyHrTest.ts

Pre-checks:

  • Changelog entry added
  • [-] Tests have been added (if applicable)
  • [-] Branch prefixed with feature/, hotfix/ or spike/

Review:

  • Milestone set
  • Docs ticket created (if applicable)

GitHub issues (if applicable):

@danoaky-tiny danoaky-tiny marked this pull request as ready for review May 20, 2024 17:48
@danoaky-tiny danoaky-tiny requested a review from a team as a code owner May 20, 2024 17:48
Co-authored-by: Andrew Herron <thespyder@programmer.net>
Copy link
Copy Markdown
Contributor

@MitchC1999 MitchC1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some reminders before you merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants